Handle network errors #1516
Open
Handle network errors #1516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trying to fix issue 1480
…3/peregrine-frontend into handle-network-errors
from pull request #1057 * Added a message for non-existent matches * Tweaked how invalid match keys are identified * Tidied up code and undid some changes * addressed the review components The lint and type checks are finding lots of errors I didn't put there, and they won't let the webpack run, so I haven't tested any of this. I'm not sure exactly how to fix all of those errors. * error fixes * fixed lint errors * test fix? * more test fixes * fixed errors * ran type and lint * lint * fixed Fragment error * rebuilt the card that appears on non-existent match * fixed normal match-page issues * aesthetic, code-shortening, lint * undo unneeded change * undid bug-fix changes * more reverting bug fixes * attempted to differentiate between different kinds of errors NEEDS TO BE TESTED * aesthetic changes Co-authored-by: Alex <[email protected]> Co-authored-by: Caleb Eby <[email protected]>
* ran build and fund * made error card
* created a more impressive 404 page * back-merged from handle-network-errors and configured the ErrorCard, still needs work that can be done on that branch --Elijah * it works now... --Elijah * slight adjustments to 404-error --Elijah * aesthetic changes * changed font styles for ErrorCard and 404-error --Elijah Co-authored-by: var Cepheid <[email protected]>
* Added message for non-existant events * Formatting for non-existent events * Fixed styling errors for non-existent event pages and network error pages. * made a few of the suggested changes I couldn't get the webpack to work, so I'm not sure if these really solve the problems. * error fixes & lint * display a message if the event does not exist The other changes involve fixing issues in the grid layout. * switched error message to ErrorCard * minor changes Co-authored-by: var Cepheid <[email protected]>
|
@varCepheid this is an intimidatingly large PR to review and test. Is it OK with you if I hold off on reviewing it until all the other open PRs get merged? That way we can avoid conflicts (even if they are not explicitly flagged by git) and make sure that everything gets tested in-depth. |
|
Yes, that's fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.