Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors in the dialog to override a report #1515

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

varCepheid
Copy link
Collaborator

@varCepheid varCepheid commented Jun 10, 2022

closes #1507
closes #1508

Makes the dialog pop up if there is an actual conflict, but not if it's just an edit.
Makes the description text in a dialog thicker so it's visible.
Adds a dialog on delete (it's not perfect but it works).

The current issues are that a) if the same user uploads a new report for the same team in the same match, it automatically overrides the old report; and b) there is no dialog to stop an accidental deletion of a report. In these changes, there are now dialogs for both of these situations.

@varCepheid varCepheid self-assigned this Jun 10, 2022
@varCepheid varCepheid added bug Addresses something that isn't working. enhancement Adds a new feature or meets a request. labels Jun 10, 2022
@varCepheid
Copy link
Collaborator Author

This replaces PR #1514, which I accidentally merged handle-network-errors into. It has all the same changes I made.

@varCepheid varCepheid requested a review from calebeby June 10, 2022 22:09
@calebeby
Copy link
Member

calebeby commented Feb 14, 2023

@varCepheid Can you add screenshots and testing instructions to this PR (in the description)?

@varCepheid
Copy link
Collaborator Author

I think they're probably in #1514 because that was the original PR. I'll move them in here when I get the chance.

@varCepheid varCepheid marked this pull request as draft February 17, 2023 00:46
@varCepheid varCepheid added the priority This needs to be addressed before the current changes can be merged to main. label Feb 17, 2023
@varCepheid varCepheid marked this pull request as ready for review February 17, 2023 01:34
@varCepheid varCepheid requested review from calebeby and removed request for calebeby February 17, 2023 01:34
@varCepheid
Copy link
Collaborator Author

I added some testing instructions in the PR description. Does that help? I checked that the changes I made did what I want them to using the deploy preview.

@varCepheid varCepheid removed the priority This needs to be addressed before the current changes can be merged to main. label Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Addresses something that isn't working. enhancement Adds a new feature or meets a request.
Projects
None yet
2 participants