-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix errors in the dialog to override a report #1515
base: dev
Are you sure you want to change the base?
Conversation
This replaces PR #1514, which I accidentally merged handle-network-errors into. It has all the same changes I made. |
@varCepheid Can you add screenshots and testing instructions to this PR (in the description)? |
I think they're probably in #1514 because that was the original PR. I'll move them in here when I get the chance. |
I added some testing instructions in the PR description. Does that help? I checked that the changes I made did what I want them to using the deploy preview. |
closes #1507
closes #1508
The current issues are that a) if the same user uploads a new report for the same team in the same match, it automatically overrides the old report; and b) there is no dialog to stop an accidental deletion of a report. In these changes, there are now dialogs for both of these situations.