Skip to content

Commit

Permalink
re-add cocoapods, cleanup android
Browse files Browse the repository at this point in the history
  • Loading branch information
albho committed Nov 19, 2024
1 parent 9d7a17e commit 2c6f898
Show file tree
Hide file tree
Showing 8 changed files with 15 additions and 40 deletions.
11 changes: 6 additions & 5 deletions .github/workflows/ios-browserstack.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,17 +35,18 @@ jobs:
- run:
pip3 install requests

- name: Install Cocoapods
run: gem install cocoapods

- name: Make build dir
run: mkdir ddp

- name: Install resource script dependency
run: |
brew update
brew install convmv
- name: Copy test_resources
run: ./copy_test_resources.sh

- name: Run Cocoapods
run: pod install

- name: Inject AccessKey
run: sed -i '.bak' 's:{TESTING_ACCESS_KEY_HERE}:${{secrets.PV_VALID_ACCESS_KEY}}:'
FalconAppTestUITests/FalconAppTestUITests.swift
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/ios-demos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@ jobs:
with:
node-version: lts/*

- name: Install Cocoapods
run: gem install cocoapods

- name: Make build dir
run: mkdir ddp

Expand Down
11 changes: 6 additions & 5 deletions .github/workflows/ios-perf.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,17 +42,18 @@ jobs:
- run:
pip3 install requests

- name: Install Cocoapods
run: gem install cocoapods

- name: Make build dir
run: mkdir ddp

- name: Install resource script dependency
run: |
brew update
brew install convmv
- name: Copy test_resources
run: ./copy_test_resources.sh

- name: Run Cocoapods
run: pod install

- name: Inject AccessKey
run: sed -i '.bak' 's:{TESTING_ACCESS_KEY_HERE}:${{secrets.PV_VALID_ACCESS_KEY}}:'
PerformanceTest/PerformanceTest.swift
Expand Down
1 change: 0 additions & 1 deletion binding/android/FalconTestApp/falcon-test-app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,6 @@ dependencies {
androidTestImplementation('androidx.test.espresso:espresso-core:3.2.0', {
exclude group: 'com.android.support', module: 'support-annotations'
})
androidTestImplementation('com.microsoft.appcenter:espresso-test-extension:1.4')
androidTestImplementation('androidx.test.espresso:espresso-intents:3.5.1')
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,7 @@

import androidx.test.platform.app.InstrumentationRegistry;

import com.microsoft.appcenter.espresso.Factory;
import com.microsoft.appcenter.espresso.ReportHelper;

import org.junit.After;
import org.junit.Before;
import org.junit.Rule;

import java.io.BufferedInputStream;
import java.io.BufferedOutputStream;
Expand All @@ -43,9 +38,6 @@

public class BaseTest {

@Rule
public ReportHelper reportHelper = Factory.getReportHelper();

Context testContext;
Context appContext;
AssetManager assetManager;
Expand All @@ -54,11 +46,6 @@ public class BaseTest {

String accessKey;

@After
public void TearDown() {
reportHelper.label("Stopping App");
}

@Before
public void Setup() throws IOException {
testContext = InstrumentationRegistry.getInstrumentation().getContext();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,6 @@
import androidx.test.ext.junit.rules.ActivityScenarioRule;
import androidx.test.ext.junit.runners.AndroidJUnit4;

import com.microsoft.appcenter.espresso.Factory;
import com.microsoft.appcenter.espresso.ReportHelper;

import org.hamcrest.Matcher;
import org.junit.After;
import org.junit.Before;
Expand Down Expand Up @@ -74,9 +71,6 @@ public void perform(UiController uiController, View view) {
@RunWith(AndroidJUnit4.class)
public class IntegrationTest {

@Rule
public ReportHelper reportHelper = Factory.getReportHelper();

@Rule
public ActivityScenarioRule<MainActivity> activityScenarioRule =
new ActivityScenarioRule<>(MainActivity.class);
Expand All @@ -91,11 +85,6 @@ public void intentsTeardown() {
Intents.release();
}

@After
public void TearDown() {
reportHelper.label("Stopping App");
}

@Test
public void testFalcon() {
onView(withId(R.id.testButton)).perform(click());
Expand Down
3 changes: 0 additions & 3 deletions binding/ios/FalconAppTest/copy_test_resources.sh
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,3 @@ cp ${RESOURCE_DIR}/audio_samples/*.wav ${ASSETS_DIR}/audio_samples

echo "Copying test data file..."
cp ${RESOURCE_DIR}/.test/test_data.json ${ASSETS_DIR}

echo "Fixing filename encodings for Appcenter compatibility"
convmv --notest -f utf8 -t utf8 --nfd -r ${ASSETS_DIR}
2 changes: 0 additions & 2 deletions resources/.lint/spell-check/dict.txt
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,6 @@ falcondemo
recyclerview
constraintlayout
gradlew
Appcenter
convmv
notest
Podfile
xcuitest
Expand Down

0 comments on commit 2c6f898

Please sign in to comment.