Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ios bitcode spm #228

Merged
merged 32 commits into from
Nov 15, 2024
Merged

Ios bitcode spm #228

merged 32 commits into from
Nov 15, 2024

Conversation

albho
Copy link
Contributor

@albho albho commented Nov 13, 2024

No description provided.

@albho
Copy link
Contributor Author

albho commented Nov 14, 2024

@matt200-ok assigned you so you could also take a look at BrowserStack-related changes

Copy link
Contributor

@matt200-ok matt200-ok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the BrowserStack changes look good

Copy link
Member

@laves laves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested to see if it reports test failures accurately? Like intentionally make a test fail and ensure you get a useful report back

@albho
Copy link
Contributor Author

albho commented Nov 14, 2024

Have you tested to see if it reports test failures accurately? Like intentionally make a test fail and ensure you get a useful report back

@laves Tested this now, and yes we do (tested perf threshold of 0 and invalid access key)

@laves laves merged commit e4eaad8 into main Nov 15, 2024
10 checks passed
@laves laves deleted the ios-bitcode-spm branch November 15, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants