Fix: Unblock v8.10 CI — .gitattributes trailing newlines + lab_sim skip-list rename#745
Merged
Merged
Conversation
Unblocks the pre-commit end-of-file-fixer hook, which CI runs with --all-files and which fails on git-lfs-generated .gitattributes that lack a final newline. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughUpdated several ChangesGit LFS asset attributes
Lab simulation objective skip update
Suggested reviewers
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/factory_sim/objectives/.gitattributes`:
- Line 1: The LFS rule in the gitattributes entry uses brace expansion syntax,
which Git does not support, so the asset files are not being matched. Replace
the single brace-based pattern with explicit Git-compatible patterns for each
file type in this attributes file, covering both lowercase and uppercase
variants so the LFS filters apply correctly to the intended assets.
In `@src/hangar_sim/description/assets/.gitattributes`:
- Line 1: The asset LFS rule in the .gitattributes entry uses brace expansion,
which Git does not support, so it will not match the intended files. Replace the
single glob in this .gitattributes rule with explicit Git patterns for each
extension, covering both lowercase and uppercase variants, and keep the same
filter=lfs, diff=lfs, merge=lfs, and -text attributes. Use the existing
.gitattributes asset rule as the target for the change.
In `@src/hangar_sim/images/.gitattributes`:
- Line 1: The .gitattributes rule currently uses brace expansion in the asset
pattern, which Git does not support, so the LFS filter will not match these
files. Update the rule in the hangar_sim images attributes entry to use explicit
Git patterns for each extension instead of the combined brace form. Keep the
existing LFS settings (filter, diff, merge, -text) and expand them into separate
patterns covering the png/jpg/jpeg and obj/dae/stl variants, including uppercase
forms as needed.
In
`@src/moveit_pro_kinova_configs/space_satellite_sim_camera_cal/description/mujoco/assets/.gitattributes`:
- Line 1: The asset tracking rule in the .gitattributes file uses unsupported
brace expansion, so it will not match the intended image and mesh files. Replace
the single glob in this attributes entry with explicit Git patterns for each
extension, keeping the same LFS settings, and ensure the rule still applies to
both lowercase and uppercase variants of the asset types.
In `@src/moveit_pro_ur_configs/mock_sim/meshes/.gitattributes`:
- Line 1: The Git LFS rule in the mock_sim meshes .gitattributes file uses brace
expansion syntax that Git attributes do not support, so the pattern never
matches the intended asset files. Replace the single brace-based rule with
explicit Git attribute patterns for each extension, covering both lowercase and
uppercase variants, so the LFS filter applies correctly to the mesh and image
files.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 2c0ea60a-14d7-4c3f-837a-dfd8c9d5bc65
📒 Files selected for processing (9)
src/factory_sim/objectives/.gitattributessrc/hangar_sim/description/assets/.gitattributessrc/hangar_sim/images/.gitattributessrc/hangar_sim/maps/.gitattributessrc/moveit_pro_franka_configs/kitchen_sim/description/mujoco/assets/kitchen_assets/textures/.gitattributessrc/moveit_pro_kinova_configs/kinova_sim/description/mujoco/assets/.gitattributessrc/moveit_pro_kinova_configs/space_satellite_sim/description/mujoco/assets/.gitattributessrc/moveit_pro_kinova_configs/space_satellite_sim_camera_cal/description/mujoco/assets/.gitattributessrc/moveit_pro_ur_configs/mock_sim/meshes/.gitattributes
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
fdavulcu
changed the title
L4co77
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
end-of-file-fixer(pre-commit, which CI runs with--all-files) fails on 9 git-lfs-generated.gitattributesfiles that lack a trailing newline. git-lfs writes these without a final newline when it tracks an asset directory, and the hook flags them across the whole tree — so it blocks every PR opened againstv8.10(#742, #743, and the unrelated #464 all fail on the same files).This adds the missing trailing newline to the 9 files. The only change per file is the final newline; no rule or content change.
Also folds in the
lab_simintegration-test fix (supersedes #750): moveit_pro renamed the visualization objective toMarker Visualization Example(commit000dfb67b5), so the staleskip_objectivesentry stopped matching and the objective ran in headless CI, where itsGetTextFromUserstep has no/request_text_from_promptsserver and failed. Correcting the name re-skips it.Bundled because the two gates are mutually blocking on
v8.10: pre-commit and the integration test each fail on the base branch, so neither fix could merge without the other.