Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimize size of ERC20 Wasm Contract #42

Merged
merged 21 commits into from
Dec 16, 2024
Merged

Conversation

sskeirik
Copy link

@sskeirik sskeirik commented Dec 14, 2024

This PR provides a build script to minimize the size of the Wasm ERC20 Contract.

I'm not sure if there any downsides to building with these flags yet, but I wanted to present this and get feedback.

@virgil-serbanuta virgil-serbanuta self-requested a review December 16, 2024 15:04
Copy link
Member

@virgil-serbanuta virgil-serbanuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only drawback that I know id that the -Z flags in build.sh are specific to nightly builds, which means that they or their functionality may change in the future. I'll approve this, but it would be nice if we could build this with a stable version.

* add kore rich header build

* update entrypoint resolution

* fix syntax error

* fix more errors

* remove deprecated comment
Base automatically changed from wasm_vm_initialization_2 to master December 16, 2024 17:18
@virgil-serbanuta virgil-serbanuta merged commit 0921a6c into master Dec 16, 2024
2 checks passed
@virgil-serbanuta virgil-serbanuta deleted the rust_minimize branch December 16, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants