Fix prove tests #40
Merged
Fix prove tests #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
traiansf
force-pushed
the
dev/traiansf/fix-tests
branch
from
8f4241e to
593e621
Compare
virgil-serbanuta
approved these changes
Dec 16, 2024
Comment on lines
+283
to
+288
| rule (L1:List ListItem(X:KItem) _:List)[size(L1)] => X | ||
| [simplification] | ||
|
|
||
| rule (L1:List ListItem(_:KItem) L2:List)[size(L1) <- V] => | ||
| L1:List ListItem(V) L2:List | ||
| [simplification] |
There was a problem hiding this comment.
Is the Haskell backend able to use these two rules?
There was a problem hiding this comment.
Yes, it' using them for the <locals> and <mem> specs: https://github.com/Pi-Squared-Inc/wasm-semantics/pull/40/files#diff-56e769c3ddbacd55039dc6c309d8126d4f9d67c1ed9cbaccdf22ac284aa971ebR8
Unfortunately, not for the wrc-20 spec. I assume the issue is that while it works as an initial configuration, it cannot be matched as a final configuration; that is why the locals-loop spec also only works when the accessed local is the last in the list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<locals>to hold aListinstead of aMap) so thatmake testpasses