Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use Pi2 fork of WASM #2

Merged
merged 8 commits into from
Aug 9, 2024
Merged

Update to use Pi2 fork of WASM #2

merged 8 commits into from
Aug 9, 2024

Conversation

dwightguth
Copy link

Here we update the MX-semantics fork to point to the fork of WASM, and fix a few issues that prevent it from compiling together.

@dwightguth dwightguth marked this pull request as ready for review August 9, 2024 20:05
Copy link

@theo25 theo25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and I will approve, but could you explain what is the huge change on the two json files?

@dwightguth
Copy link
Author

Yes, I can. These JSON files store a representation of a mx-semantics configuration that is used to populate the initial configuration of krun by kmultiversx. When we changed the configuration structure of the wasm semantics, these files became out of date and needed to be regenerated. RV provided a tool to do this so I just ran it and checked in the modified files. If you do a word diff between the two versions, you will see that the differences entirely consist of those changes we made to the configuration structure of our WASM fork.

@dwightguth dwightguth merged commit 4103aff into master Aug 9, 2024
3 checks passed
@dwightguth dwightguth deleted the poetry branch August 9, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants