Final Pull Request #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MishaSavchenko
approved these changes
May 25, 2017
Collaborator
MishaSavchenko
left a comment
MishaSavchenko
left a comment
There was a problem hiding this comment.
I really like your readme, it's very comprehensive and does a good job of showing what you code is really about. The code itself is very descriptive and does a each function does a good job of explaining what it does.
In the exoplanet_mcmc folder I dont think that you need to push the pycache folder as it is created automatically.
The requirements I think should be in a section of the readme file, but im not really sure about that. Does it interact with you travis.yml or is just to inform the user about the modules you used?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.