-
Notifications
You must be signed in to change notification settings - Fork 239
Fix OpenCV version checking error #1963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Jade Turner <[email protected]>
The comment on chief Delphi also had a missing return character. Could you add that here? |
The other failure mode is a vendor dependency, pulling in something stupid. Should we mention that? |
Perhaps something about how the versions need to match, not just about they need to be upgraded? |
Something like |
I wouldn't bother unless you can think of a vendor which does, it would only lead people down the wrong path right now.
Versions needing to match is difficult, we often have mismatching versions. If they are both latest it should work. |
Signed-off-by: Jade Turner <[email protected]>
@@ -231,11 +231,12 @@ public static void verifyDependencies() { | |||
+ "\n" | |||
+ ">>> but you are using OpenCV " | |||
+ Core.VERSION | |||
+ "\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C++ already has this
There should be an explanation on the |
Description
Fixed the error in the OpenCV version checking crash.
Reported on chief https://www.chiefdelphi.com/t/opencv-is-version-4-6-0-and-needs-to-be-4-10-0/501751/7
Meta
Merge checklist: