Skip to content

Add camera mismatch banner to dashboard #1921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

alaninnovates
Copy link
Contributor

Description

Detects if a camera mismatch is present in any camera and displays a banner in the dashboard for better visibility to the user.

image

Closes #1920

Meta

Merge checklist:

  • Pull Request title is short, imperative summary of proposed changes
  • The description documents the what and why
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with settings back to v2024.3.1
  • If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
  • If this PR addresses a bug, a regression test for it is added

@alaninnovates alaninnovates requested a review from a team as a code owner April 19, 2025 05:53
@samfreund
Copy link
Member

Looks good, I'll test when I have a chance.

@crschardt
Copy link
Contributor

This is all front-end code. Shouldn't we also involve the back-end, at least to log that there is a conflict?

@samfreund
Copy link
Member

Yea I agree with Craig. If we could just get a log message, ideally with the camera that should be there, and the camera that is there. This should only happen once, when the camera is initially connected and mismatched.

@samfreund
Copy link
Member

I'm no longer seeing a mismatch banner at all, even if there is a mismatch present.

@samfreund
Copy link
Member

Can we add some language about how matching is performed using USB port to the banner?

@alaninnovates alaninnovates requested a review from samfreund April 28, 2025 21:42
@samfreund
Copy link
Member

I'm no longer seeing a mismatch banner at all, even if there is a mismatch present.

This is still the case, not quite sure what changed but it's no longer working.

return baseName.equals(info.baseName) && equals(info);
}
if (obj instanceof PVCameraInfo info) {
return equals(info);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need this extra code? what does this equals normally end up checking for records?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

equals() in PVCameraInfo checks for uniquePath equality. each specific equals() method compares more properties to ensure equality. these checks were based off of what was on the camera matching code in the web ui code

Copy link
Contributor

@mcm001 mcm001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like new logic was added to VisionSourceManager. Let's make sure we also unit test this.

@samfreund samfreund added the enhancement New feature or request label May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make camera mismatch message more prominent
4 participants