-
Notifications
You must be signed in to change notification settings - Fork 239
Add camera mismatch banner to dashboard #1921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add camera mismatch banner to dashboard #1921
Conversation
Looks good, I'll test when I have a chance. |
This is all front-end code. Shouldn't we also involve the back-end, at least to log that there is a conflict? |
Yea I agree with Craig. If we could just get a log message, ideally with the camera that should be there, and the camera that is there. This should only happen once, when the camera is initially connected and mismatched. |
photon-core/src/main/java/org/photonvision/vision/processes/VisionSourceManager.java
Outdated
Show resolved
Hide resolved
I'm no longer seeing a mismatch banner at all, even if there is a mismatch present. |
Can we add some language about how matching is performed using USB port to the banner? |
This is still the case, not quite sure what changed but it's no longer working. |
return baseName.equals(info.baseName) && equals(info); | ||
} | ||
if (obj instanceof PVCameraInfo info) { | ||
return equals(info); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need this extra code? what does this equals normally end up checking for records?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
equals() in PVCameraInfo checks for uniquePath equality. each specific equals() method compares more properties to ensure equality. these checks were based off of what was on the camera matching code in the web ui code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like new logic was added to VisionSourceManager. Let's make sure we also unit test this.
Description
Detects if a camera mismatch is present in any camera and displays a banner in the dashboard for better visibility to the user.
Closes #1920
Meta
Merge checklist: