Reenable and fix flaky tests #1837
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Descriptive! |
|
Whoops, I forgot to switch the repo to my fork. |
|
Well, at least we know which tests are failing. Seems to have gotten worse than when we disabled them. |
|
Yeah. It seems they have bitrotted |
Gold856
force-pushed
the
tests
branch
4 times, most recently
from
2db2104 to
3d096a5
Compare
|
Investigation concluded that the construction of PhotonCamera in a prior test causes testAlerts to fail. Likely due to retained state with Alerts. |
Gold856
force-pushed
the
tests
branch
6 times, most recently
from
82d2438 to
c569fb3
Compare
Gold856
force-pushed
the
tests
branch
3 times, most recently
from
ce448d6 to
8d4cc40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It looks like at some point during WPILib's development, the NT issues that were plaguing us were fixed. Due to the fact that Alerts cannot be properly reset in unit tests, the ordering of PhotonCameraTest has been fixed such that
testAlertsis always first, and therefore is not impacted by the NT instances being reset. In addition, unit tests are now executed such that each class is given its own JVM so we don't run into the 16 NT instance limit.Closes #1574.
Meta
Merge checklist: