[Examples] Limit minimum battery voltage in sim to 0.1V #1600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occasionally, the sim projects are capable of simulating current draw of over 600A, which triggers a condition in
BatterySim::calculateDefaultBatteryLoadedVoltagethat limits the minimum measured battery voltage to 0V (to prevent it from going negative).When battery voltage measures 0, this causes NaN values to propagate through the drivetrain model, making sim inoperable. Specifically, this is the line that causes the initial NaN values in simulation.
This PR is posed as a patch to ensure that simulation doesn't break.