This repository has been archived by the owner on Jul 16, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 56
Reorganized documentation and added new articles #297
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no clue why the Chief Delphi links are failing now |
This was
linked to
issues
Nov 23, 2023
Closed
* fix links * removed one more linl
* initial docs for sim overhaul * adding highlighting and moving akit to end of file * renamed to deprecated vs legacy * new graphic * Update source/docs/programming/photonlib/simulation-deprecated.rst Co-authored-by: Mohammad Durrani <[email protected]> * Update source/docs/programming/photonlib/simulation-deprecated.rst Co-authored-by: Mohammad Durrani <[email protected]> * Update source/docs/programming/photonlib/simulation-deprecated.rst Co-authored-by: Mohammad Durrani <[email protected]> * wording rewrites * rewording suggestions and new graphic * removing Akit refs * removing literal link to example frame * lint fixes * legacy support admonition * fix simulation-deprecated warnings * rewrite simulation page with links to examples * split up PhotonCameraSim blurb * Addressed PR comments * Fix trailing whitespace --------- Co-authored-by: Mohammad Durrani <[email protected]> Co-authored-by: amquake <[email protected]> Co-authored-by: Matt <[email protected]> Co-authored-by: shueja <[email protected]>
gerth2
previously approved these changes
Dec 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very solid overall. A few wording nits
* Add build instructions for deploy Because I always forget the command * typeos and adding clean commands * comment and scope creep
Co-authored-by: Chris Gerth <[email protected]>
Co-authored-by: Chris Gerth <[email protected]>
Co-authored-by: Chris Gerth <[email protected]>
Co-authored-by: Chris Gerth <[email protected]>
Co-authored-by: Chris Gerth <[email protected]>
Co-authored-by: Chris Gerth <[email protected]>
Co-authored-by: Chris Gerth <[email protected]>
Co-authored-by: Chris Gerth <[email protected]>
Co-authored-by: Chris Gerth <[email protected]>
Co-authored-by: Chris Gerth <[email protected]>
Co-authored-by: Chris Gerth <[email protected]>
Co-authored-by: Chris Gerth <[email protected]>
Co-authored-by: Chris Gerth <[email protected]>
Co-authored-by: Chris Gerth <[email protected]>
mcm001
reviewed
Jan 1, 2024
mcm001
previously approved these changes
Jan 2, 2024
mdurrani808
dismissed
mcm001’s stale review
January 2, 2024 22:38
The merge-base changed after approval.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added:
Did some basic reorganization as well to make this more approachable.