Skip to content
This repository has been archived by the owner on Jul 16, 2024. It is now read-only.

Reorganized documentation and added new articles #297

Merged
merged 35 commits into from
Jan 3, 2024

Conversation

mdurrani808
Copy link
Contributor

Added:

  • networking diagram
  • 3D Coordiante systems
  • Reorganized getting started
  • Removed AprilTag example page
  • Added note on AruCo vs AprilTag
  • Added page on MultiTag, needs docs
  • Basic system requirements

Did some basic reorganization as well to make this more approachable.

@mdurrani808
Copy link
Contributor Author

no clue why the Chief Delphi links are failing now

mdurrani808 and others added 2 commits December 20, 2023 22:09
* fix links

* removed one more linl
* initial docs for sim overhaul

* adding highlighting and moving akit to end of file

* renamed to deprecated vs legacy

* new graphic

* Update source/docs/programming/photonlib/simulation-deprecated.rst

Co-authored-by: Mohammad Durrani <[email protected]>

* Update source/docs/programming/photonlib/simulation-deprecated.rst

Co-authored-by: Mohammad Durrani <[email protected]>

* Update source/docs/programming/photonlib/simulation-deprecated.rst

Co-authored-by: Mohammad Durrani <[email protected]>

* wording rewrites

* rewording suggestions and new graphic

* removing Akit refs

* removing literal link to example frame

* lint fixes

* legacy support admonition

* fix simulation-deprecated warnings

* rewrite simulation page with links to examples

* split up PhotonCameraSim blurb

* Addressed PR comments

* Fix trailing whitespace

---------

Co-authored-by: Mohammad Durrani <[email protected]>
Co-authored-by: amquake <[email protected]>
Co-authored-by: Matt <[email protected]>
Co-authored-by: shueja <[email protected]>
gerth2
gerth2 previously approved these changes Dec 29, 2023
Copy link
Contributor

@gerth2 gerth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very solid overall. A few wording nits

source/docs/apriltag-pipelines/3D-tracking.rst Outdated Show resolved Hide resolved
source/docs/apriltag-pipelines/3D-tracking.rst Outdated Show resolved Hide resolved
source/docs/apriltag-pipelines/3D-tracking.rst Outdated Show resolved Hide resolved
source/docs/apriltag-pipelines/about-apriltags.rst Outdated Show resolved Hide resolved
source/docs/apriltag-pipelines/coordinate-systems.rst Outdated Show resolved Hide resolved
source/docs/apriltag-pipelines/coordinate-systems.rst Outdated Show resolved Hide resolved
source/docs/apriltag-pipelines/coordinate-systems.rst Outdated Show resolved Hide resolved
source/docs/apriltag-pipelines/images/camera-coord.png Outdated Show resolved Hide resolved
source/docs/hardware/selecting-hardware.rst Outdated Show resolved Hide resolved
source/docs/programming/photonlib/robot-pose-estimator.rst Outdated Show resolved Hide resolved
* Add build instructions for deploy

Because I always forget the command

* typeos and adding clean commands

* comment and scope creep
mdurrani808 and others added 17 commits December 30, 2023 17:52
source/docs/apriltag-pipelines/3D-tracking.rst Outdated Show resolved Hide resolved
source/docs/apriltag-pipelines/3D-tracking.rst Outdated Show resolved Hide resolved
source/docs/pipelines/input.rst Outdated Show resolved Hide resolved
mcm001
mcm001 previously approved these changes Jan 2, 2024
source/docs/apriltag-pipelines/3D-tracking.rst Outdated Show resolved Hide resolved
@mdurrani808 mdurrani808 dismissed mcm001’s stale review January 2, 2024 22:38

The merge-base changed after approval.

@mcm001 mcm001 merged commit d8c6b3a into PhotonVision:master Jan 3, 2024
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants