Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid massive stack-allocs #10

Merged
merged 3 commits into from
Nov 17, 2024
Merged

Avoid massive stack-allocs #10

merged 3 commits into from
Nov 17, 2024

Conversation

mcm001
Copy link
Collaborator

@mcm001 mcm001 commented Nov 17, 2024 •
edited
Loading

So my code was also allocating a ton. For 588 photos of a 10x10 cal object, I have removed:

  • 7KB from c_observations_board
  • 28224 bytes from b_packed_final
  • 940800 bytes from c_x_final

A quick audit of mrcal shows a good chunk of stack allocations, but nothing on this order of magnitude. Whoops. My bad.

@mcm001 mcm001 mentioned this pull request Nov 17, 2024
Merged
@mcm001 mcm001 merged commit 41d7868 into main Nov 17, 2024
4 checks passed
@mcm001 mcm001 deleted the 20241116_stack_kaboom_fix branch November 17, 2024 08:33
@mcm001 mcm001 mentioned this pull request Nov 18, 2024
Draft
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mcm001