Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spirillen patch 1 #2

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Spirillen patch 1 #2

wants to merge 7 commits into from

Conversation

spirillen
Copy link
Contributor

@spirillen spirillen commented Dec 18, 2024

Commit for preview and properly a lot of git issues adding this on to the renamed branch

This commits

  • issue templates
  • README.md
  • .gitignore

Please add any comments for enhancement

spirillen and others added 4 commits December 18, 2024 10:08
This should at best be the default bug report template for https://github.com/Phishing-Database/
Trying to fix the project assigment
This commits

- issue templates
- README.md
- .gitignore
@spirillen spirillen self-assigned this Dec 18, 2024
@spirillen spirillen marked this pull request as ready for review December 18, 2024 12:59
Copy link

@g0d33p3rsec g0d33p3rsec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I only see a couple of minor grammatical edits.


!WIP
The Phishing database project aim's to provide up-to-date list of domains and URI there is hosting phishing contents.
Copy link

@g0d33p3rsec g0d33p3rsec Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence could use a couple of minor grammatical edits, I would adjust it to something like "The Phishing database project's aim is to provide an up-to-date list of domains and URIs that are hosting phishing contents."

Another possibility would be to omit the apostrophe entirely, "The Phishing database project aims..."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accepted 👍🏻 thanks for the comment.

🍿 Fun facts - what does your team eat for breakfast?
🧙 Remember, you can do mighty things with the power of [Markdown](https://docs.github.com/github/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax)
-->
In the following table, you'll find links to our datasets and it's checksum.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can safely omit the apostrophe for "it's."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accepted 👍🏻 thanks for the comment.

Both comments should be applied by now

Thanks to @g0d33p3rsec for his comments.

Always nice with a natively speaking feedback's 😄 

Signed-off-by: spirillen <[email protected]>
@spirillen
Copy link
Contributor Author

@funilrys and @mitchellkrogza any comments? so we can get on with the welcome page and close Phishing-Database/dev-center#2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants