-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spirillen patch 1 #2
base: master
Are you sure you want to change the base?
Conversation
DRAFT
This should at best be the default bug report template for https://github.com/Phishing-Database/
Trying to fix the project assigment
This commits - issue templates - README.md - .gitignore
Signed-off-by: spirillen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I only see a couple of minor grammatical edits.
profile/README.md
Outdated
|
||
!WIP | ||
The Phishing database project aim's to provide up-to-date list of domains and URI there is hosting phishing contents. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence could use a couple of minor grammatical edits, I would adjust it to something like "The Phishing database project's aim is to provide an up-to-date list of domains and URIs that are hosting phishing contents."
Another possibility would be to omit the apostrophe entirely, "The Phishing database project aims..."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accepted 👍🏻 thanks for the comment.
profile/README.md
Outdated
🍿 Fun facts - what does your team eat for breakfast? | ||
🧙 Remember, you can do mighty things with the power of [Markdown](https://docs.github.com/github/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax) | ||
--> | ||
In the following table, you'll find links to our datasets and it's checksum. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can safely omit the apostrophe for "it's."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accepted 👍🏻 thanks for the comment.
Both comments should be applied by now
Thanks to @g0d33p3rsec for his comments. Always nice with a natively speaking feedback's 😄 Signed-off-by: spirillen <[email protected]>
@funilrys and @mitchellkrogza any comments? so we can get on with the welcome page and close Phishing-Database/dev-center#2 |
Commit for preview and properly a lot of git issues adding this on to the renamed branch
This commits
Please add any comments for enhancement