Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swiftlint config and inital formatting pass #765

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

ened
Copy link
Contributor

@ened ened commented Jul 9, 2023

Initial stab at formatting as discussed in #760

This is not integrated in CI/CD yet, but only tries to do light formatting to get started.

cc @remonh87 @Taym95

@ened ened changed the title swiftlint config and iniital format swiftlint config and inital formatting pass Jul 9, 2023
@ened
Copy link
Contributor Author

ened commented Jul 9, 2023

cc @werediver

- Pods
- "**/*.pb.swift" # exclude files with a wildcard

line_length: 300
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doubt we have lines longer than 120 characters, but... if it was not enforced or checked, who knows.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it so that there are no warnings (we have a few). The ruleset could be reduced and refined with future PRs (out of scope for this one IMHO).

@ened
Copy link
Contributor Author

ened commented Jul 10, 2023

@werediver need your help to merge it, please :)

@werediver werediver merged commit f474fe7 into PhilipsHue:master Jul 10, 2023
@ened ened deleted the swiftlint branch July 10, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants