-
-
Notifications
You must be signed in to change notification settings - Fork 31
Add Korean URL shorteners #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. 📝 WalkthroughWalkthroughExpanded the URL shortener domain list by adding multiple new entries to the exported Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @hanjm-github, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the repository's ability to recognize and handle shortened URLs by integrating a comprehensive set of newly identified Korean URL shortener domains. The update ensures that the list remains current and globally relevant, particularly for content originating from the Korean web, thereby improving the overall utility and accuracy of the shortener detection mechanism. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
Thank you for adding a list of Korean URL shorteners. The new domains are all correctly sorted within the list. I've found one potential issue with an added domain that was not listed in the pull request description and may not fit the scope of this change. I've left a specific comment about it. Also, I noticed the pull request description had a typo juso..ga, which you correctly added as juso.ga in the list - great catch!
Description
Add Korean URL shorteners
a.to
abit.ly
buly.kr
chzzk.me
glol.in
gourl.kr
iri.my
juso.ga
linc.kr
lrl.kr
muz.so
nu.gl
shor.kr
ssib.al
t2m.kr
tny.kr
tuney.kr
url.kr
url.sg
zed.kr
zrr.kr
zurl.kr
zza.ng
zzo.kr
Domain Usage Proof
I checked all of the sites are working, but I couldn't provide all of examples because of time.
a.to
shor.kr
ssib.al
Checklist
Rationale
Explain why these domains should be added or removed (e.g., inactive, false positive, newly found).
newly found
Additional Notes
Summary by CodeRabbit