fix(deps): bump golang.org/x/crypto and migrate yaml.v3 to maintained fork#3009
fix(deps): bump golang.org/x/crypto and migrate yaml.v3 to maintained fork#3009jeremylem wants to merge 1 commit into
Conversation
β¦ fork Resolves SSH-subpackage CVEs in golang.org/x/crypto and removes the runtime dependency on the archived gopkg.in/yaml.v3 module. Changes: - golang.org/x/crypto v0.51.0 -> v0.53.0 (indirect, fixes GO-2026-5005, 5006, 5013, 5014, 5015, 5016, 5017, 5018, 5019, 5020, 5021, 5023, 5033) - gopkg.in/yaml.v3 v3.0.1 -> go.yaml.in/yaml/v3 v3.0.4: migrate the two runtime imports in pkg/development/file/decoder.go and pkg/development/development.go to the maintained successor module. The previous module path gopkg.in/yaml.v3 was archived upstream in April 2024 and will not receive future patches. go.yaml.in/yaml/v3 is the actively maintained community fork and was already present as an indirect dependency in this repo. Verification: - go build ./cmd/permify: ok - go vet ./...: ok - go test ./pkg/development/...: ok - govulncheck ./cmd/permify (source mode): No vulnerabilities found - govulncheck -mode=binary on the resulting binary: No vulnerabilities found
|
All contributors have signed the CLA βοΈ β
|
|
No actionable comments were generated in the recent review. π βΉοΈ Recent review infoβοΈ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: β Files ignored due to path filters (1)
π Files selected for processing (3)
π WalkthroughWalkthroughTwo source files ( ChangesYAML library migration and dependency bump
Estimated code review effortπ― 1 (Trivial) | β±οΈ ~3 minutes Poem
π₯ Pre-merge checks | β 5β Passed checks (5 passed)
βοΈ Tip: You can configure your own custom pre-merge checks in the settings. β¨ Finishing Touchesπ§ͺ Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I have read the CLA Document and I hereby sign the CLA |
Summary
This PR resolves two security findings reported by container image scanners against the v1.7.1 release:
golang.org/x/crypto v0.51.0β all in thesshsubpackage. Bumped to v0.53.0 (latest as of 2026-06-19), which contains the upstream fixes (GO-2026-5005, 5006, 5013, 5014, 5015, 5016, 5017, 5018, 5019, 5020, 5021, 5023, 5033).gopkg.in/yaml.v3 v3.0.1end-of-life β the upstreamgo-yaml/yamlrepository was archived in April 2024 and will not receive further patches. Migrated the two runtime imports togo.yaml.in/yaml/v3 v3.0.4, the actively maintained community successor that was already present in this repo as an indirect dependency.Changes
go.mod/go.sum: bumpgolang.org/x/cryptoto v0.53.0; promotego.yaml.in/yaml/v3from indirect to direct require; drop the direct require ongopkg.in/yaml.v3. Routinego mod tidyalso bumpsgolang.org/x/sync,sys,term,text, andtoolsto current patch versions.pkg/development/file/decoder.goandpkg/development/development.go: swap the yaml import path. No API or behaviour changes βgo.yaml.in/yaml/v3is a drop-in replacement that exports the sameyaml.Marshal/yaml.Unmarshal.Note:
gopkg.in/yaml.v3still appears as// indirectingo.modbecausegolangci-lint(a build-time developer tool) transitively requires it. It is not in the production binary's call graph.Verification
go build ./cmd/permifygo vet ./...go test ./pkg/development/...govulncheck ./cmd/permify(source mode)govulncheck -mode=binaryagainst the resulting binaryBefore this change,
govulncheckreported 13 SSH-subpackage vulnerabilities present in the binary (none reachable frommainper source-mode analysis, but still flagged by container scanners). After this change, both modes return clean.Compatibility
go.yaml.in/yaml/v3v3.0.x has the same public API asgopkg.in/yaml.v3v3.0.x β the migration is a straight import-path rename, no code adjustments needed.golang.org/x/cryptov0.53.0 is API-compatible with v0.51.0.Summary by CodeRabbit