Skip to content

fix(lexer): prevent panic on unterminated string literal #3005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kanywst wants to merge 1 commit into
base: master
Choose a base branch
from
+20 −1
Open

fix(lexer): prevent panic on unterminated string literal #3005

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion pkg/dsl/lexer/lexer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,13 @@ func (l *Lexer) lexString() string {
}
l.readChar()
}
str += l.input[position:l.position]
end := l.position
if end > len(l.input) {
end = len(l.input)
}
if position < end {
str += l.input[position:end]
}
if l.ch == '"' {
l.readChar()
}
Expand Down
13 changes: 13 additions & 0 deletions pkg/dsl/lexer/lexer_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1189,4 +1189,17 @@ rule test_rule(created_at time, started_at time) {
Expect(hasBoolean).Should(BeTrue())
Expect(hasComparison).Should(BeTrue())
})

It("Case 4 - should not panic on an unterminated string", func() {
for _, input := range []string{`"\`, `"`, `"abc\`, `"\\`} {
Expect(func() {
l := NewLexer(input)
for {
if l.NextToken().Type == token.EOF {
break
}
}
}).ShouldNot(Panic())
}
})
})
Loading