embed.pl: Tidy up embed.fnc flags error checking #24007
Open
+43
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the same format and similar wording for these for consistency.
By using a regex capture group we can collapse several statements
This and the next 5 commits move some error checks around to be adjacent. The code had gotten kind of wild. This regularizes it.
A means there is unlimited proclaimed external visibility
C means there is unlimited reluctant external visibility, that isn't
announced.
S means there shouldn't be external visibility because the symbol is
static to the file declaring it.
The error message here was not very clear. And the previous commit just added a check ruling out both A and C being present, so the error message no longer needs to have weasel words for that case.
Fit into 78 columns
khwilliamson
added
the
Use merge commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series of commits mostly just moves code around and tidies things so that the error checking of flags in embed.fnc lines is more coherent.
It adds two checks that had been omitted. A symbol can't both be one type of macro, and another type of macro; nor public and non-public, and we don't want symbols whose names begin with
S_to be public. (We wantPerl_for those.)