eliminate more trivial format strings ("%s", "...")#23127
Merged
mauke merged 2 commits intoPerl:bleadfrom Mar 18, 2025
Merged
Conversation
As a follow-up to commit 71d1d45, turn more trivial format strings (i.e. "%s" followed by a string literal) into just that string literal. - dump.c: String literals are more efficiently appended using sv_catpvs; C strings using sv_patv. No need to invoke the entire sv_catpvf machinery to parse a static "format string" of length 1. - malloc.c: Disentangle some warning messages and make them properly match their (previously orphaned) perldiag entries again. - os2/perlrexx.c: Turn sprintf(x, "...") into strcpy(x, "...").
Before:
malloc.c: In function ‘getpages’:
malloc.c:273:34: warning: ignoring return value of ‘write’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
273 | # define fatalcroak(mess) (write(2, (mess), strlen(mess)), exit(2))
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
malloc.c:1546:21: note: in expansion of macro ‘fatalcroak’
1546 | fatalcroak("panic: Off-page sbrk\n");
| ^~~~~~~~~~
malloc.c:273:34: warning: ignoring return value of ‘write’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
273 | # define fatalcroak(mess) (write(2, (mess), strlen(mess)), exit(2))
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
malloc.c:1585:13: note: in expansion of macro ‘fatalcroak’
1585 | fatalcroak("Misalignment of sbrk()\n");
| ^~~~~~~~~~
gcc -c -DPERL_CORE -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -std=c99 -O2 -Wall -Werror=pointer-arith -Werror=vla -Wextra -Wno-long-long -Wno-declaration-after-statement -Wc++-compat -Wwrite-strings -Wno-use-after-free universal.c
(The "make depend" comment was overlooked in commit b9e5552.)
ilmari
approved these changes
Mar 18, 2025
Leont
approved these changes
Mar 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a follow-up to commit 71d1d45, turn more trivial format strings (i.e.
"%s"followed by a string literal) into just that string literal.sv_catpvs; C strings usingsv_patv. No need to invoke the entiresv_catpvfmachinery to parse a static "format string" of length 1.sprintf(x, "...")intostrcpy(x, "...").