Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_PC_CHOWN_RESTRICTED can only be used via pathconf/fpathconf not sysconf #22156

Closed
wants to merge 1 commit into from

Conversation

BernardQuatermass
Copy link

The documentation regarding availability of chown (perldoc -f chown) incorrectly uses the sysconf() function rather than the pathconf() function along with a path.

PC* can only be used as parameters to pathconf()/fpathconf(). Only SC* values can be used against sysconf().

Cannot speak to other systems but on all linux systems the original code would be returning the value for "_SC_TZNAME_MAX, The maximum number of bytes in a timezone name."

There is also an matching misuse in cpan/File-Temp/lib/File/Temp.pm

@mauke
Copy link
Contributor

mauke commented Apr 18, 2024

The modules in cpan/ are maintained elsewhere (see Perl-Toolchain-Gang/File-Temp#41). The change to File::Temp should be reverted.

The change to perlfunc.pod looks good to me.

@jkeenan
Copy link
Contributor

jkeenan commented Apr 20, 2024

The modules in cpan/ are maintained elsewhere (see Perl-Toolchain-Gang/File-Temp#41). The change to File::Temp should be reverted.

Yes, there should be no change to File::Temp in this p.r.; that should be done upstream.

@BernardQuatermass, can you run perl Porting/updateAUTHORS.pl to add your name and email address to our AUTHORS file, then re-push? thanks.

The change to perlfunc.pod looks good to me.

@mauke
Copy link
Contributor

mauke commented Apr 21, 2024

Replaced by #22161.

@mauke mauke closed this Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants