make_executable.t: ensure PATH for test is not too long, as that is incompatible with win2k #18118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wchristian
force-pushed
the
pl2bat_win2k_fix
branch
from
8eda0f3 to
70752d1
Compare
…ncompatible with win2k
wchristian
force-pushed
the
pl2bat_win2k_fix
branch
from
70752d1 to
463ac8d
Compare
|
Applied some feedback from IRC. Any other objections to this being merged? |
|
@Leont Ping? :) |
atoomic
reviewed
Sep 15, 2020
|
|
||
| sub construct_test_PATH { | ||
| my $perl_path = $^X; | ||
| my $cmd_path = $ENV{ComSpec} || `where cmd`; # where doesn't seem to work on all windows versions |
There was a problem hiding this comment.
should not we check for $? when it fails?
atoomic
reviewed
Sep 15, 2020
atoomic
reviewed
Sep 15, 2020
| note "using perl executable name: $perl"; | ||
|
|
||
| local $ENV{PATH} = $path_with_cwd; | ||
| my $test_out = `$perl -e 1 2>&1`; |
There was a problem hiding this comment.
maybe check $? in addition to the output?
There was a problem hiding this comment.
Yeah, i can add that.
atoomic
requested changes
Sep 15, 2020
toddr
added a commit
that referenced
this pull request
Sep 18, 2020
Goes with #18118. Per ilmari, this is ok to push in while we wait for Perl-Toolchain-Gang/extutils-pl2bat#6 to merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to ilmari this can be integrated into blead directly, as it is strictly a test fix.
This is a companion to Perl-Toolchain-Gang/extutils-pl2bat#6 which will need further work before it can be integrated, while the test fix can go in directly.
It is also the solution to #18104