Add support for HTTP Basic auth in httplite, iosock, and lynx. #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
The original impetus for this PR was a request by @karenetheridge. |
Member
Huh! when? :) |
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HTTP Basic authentication test (disabled in d0b0813 / 0.52) was constantly failing because the underlying feature was not properly implemented in httplite, lynx, or iosock.
This PR re-enables the test and adds the functionality to those methods.
The problem with the 'httplite' method was due to a bug in the HTTP::Lite module that incorrectly parses URLs with a userinfo portion. I've raised neilb/HTTP-Lite#2 for that. In the meantime, this works around the issue by rebuilding the URL without the userinfo portion (since it's passed in via a request header anyway).
The 'iosock' method was never getting the userinfo because of the way the interface works, so I've added the request header for that, too.
And lynx, for some reason, requires the userinfo to be passed via the command-line. It seems to allow it in the URL, but it doesn't actually make use of the information there.