Fixes for 32-bit Swift (arm) #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The changes in Sources/NetTCP.swift will not work on 4.1, but the changes in Sources/NetTCPSSL.swift saved my day. This should be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are a bit ugly. The issue with INADDR_CONST is that I have to tell Swift very explicitly (this feels like a swift bug to me) the bit pattern type. The literal constant is stubbornly interpreted as a Int, which being 32-bit, would overflow (swift protects the sign bit).
The change to NetTCPSSL.swift is because the api is slightly different. So, this just traps the arm case and coerces the type.