PKG-1228: Migrate check_mysql_repo job from REL to PS80 #3770
Conversation
nogueiraanderson
force-pushed
the
PKG-1228
branch
from
d39250c to
cf1707a
Compare
nogueiraanderson
requested review from
a team,
kaushikpuneet07,
mchawla16,
mohitj1988 and
panchal-yash
as code owners
nogueiraanderson
force-pushed
the
PKG-1228
branch
2 times, most recently
from
f874b7a to
8f27535
Compare
Migrate MySQL tag monitoring job with improvements: - Move pipeline from rel/jenkins to ps/jenkins - Add mysql_commit_report.py to ps/scripts/ (from private mysql-eol-dev) - Post notifications to both #mysql and #eol-dev Slack channels - Add MySQL 9.x series monitoring (9.0, 9.1, 9.2) - Use filtered git clone for faster execution (~100MB vs 1.5GB) - Add CSV output validation - Add JJB YAML configuration - Add AI analysis parameters with env var fallback (disabled by default) Related: PKG-1228
nogueiraanderson
force-pushed
the
PKG-1228
branch
from
8f27535 to
fde010e
Compare
VarunNagaraju
left a comment
VarunNagaraju
left a comment
There was a problem hiding this comment.
The slack message from the job to the #eol-dev and #mysql channels looks good.
Could you please address the following review comments?
Cheers,
Varun
| sh 'mkdir -p csv_output' | ||
|
|
||
| // Define version patterns to track | ||
| def versionPatterns = ['mysql-5.7', 'mysql-8.0', 'mysql-8.4', 'mysql-9.0', 'mysql-9.1', 'mysql-9.2'] |
There was a problem hiding this comment.
MySQL 5.7 is already EOL and upstream hasn't published any new mysql-5.7 tags in 2 years. So, we don't need this versionPattern.
Also, we just need mysql-8.0 and mysql-8.4 patterns for now since we're providing post-EOL support to 5.7 and 8.0 we'll be backporting fixes identified in mysql-8.0 to our 5.7 versions and mysql-8.4 to 8.0 versions.
So, please remove the rest and keep only mysql-8.0 and mysql-8.4.
| python3 ps/scripts/mysql_commit_report.py \ | ||
| -i mysql-server-repo \ | ||
| -o csv_output \ | ||
| -g \ |
There was a problem hiding this comment.
Can we have an option in the job similar to AI analysis for -g with the name generate-per-component-csv and pass the option -g only when that boolean option is enabled?
The option should be disabled/set to false by default.
There was a problem hiding this comment.
Can we use curl or another mechanism to download this script as part of the Jenkins job instead of duplicating it across two repositories? Duplicating the script means any bug fixes would need to be made in multiple places, increasing the risk of inconsistencies.
| ) | ||
| string( | ||
| name: 'LLM_MODEL', | ||
| defaultValue: 'gemini-2.0-flash', |
There was a problem hiding this comment.
The default value should be gemini-3-pro.
|
|
||
| // AI analysis: parameter takes precedence, then env var | ||
| def enableAI = params.ENABLE_AI_ANALYSIS ?: (env.ENABLE_AI_ANALYSIS == 'true') | ||
| def llmModel = params.LLM_MODEL ?: env.LLM_MODEL ?: 'gemini-2.0-flash' |
There was a problem hiding this comment.
The default value should be gemini-3-pro.
2 participants
Summary
check_mysql_repojob from REL to PS80gen_csv_diff.shwithmysql_commit_report.py#mysqland#eol-devSlack channels with link to CSV artifactsChanges
ps/jenkins/check_mysql_repo.groovyps/jenkins/check_mysql_repo.ymlps/scripts/mysql_commit_report.pyrel/jenkins/check_mysql_repo.groovyParameters
ENABLE_AI_ANALYSISfalseLLM_MODELgemini-2.0-flashTesting
Jira: https://perconadev.atlassian.net/browse/PKG-1228