Fix EC2 cost calculation in staging notification Lambda #3595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove separate cloud/aws-functions/email_running_instances.py file - Keep Lambda code inline in IaC/StagingStack.yml for simpler deployment - Remove AWS CLI example command from template header - Fix YAML formatting: proper comment spacing and remove trailing whitespaces
- Fix email_running_instances Lambda: accurate cost calculation for spot/on-demand instances - Calculate time-weighted costs based on actual spot price history - Add richer email format with instance type, lifecycle, and region/AZ info - Fix Python 3 compatibility issues with filter() function - Clean up YAML formatting: fix comment spacing and remove trailing whitespaces
nogueiraanderson
changed the title
- Add AWS Pricing API integration for accurate on-demand pricing - Remove inaccurate spot × 2 fallback estimation - Add pricing:GetProducts IAM permission to Lambda role - Keep describe_spot_price_history for spot instances (API doesn't provide spot prices) - Limit region support to US and Europe only - Fix YAML formatting: remove trailing whitespaces and extra spaces before comments - Update email recipient list
ademidoff
reviewed
Oct 6, 2025
| def lambda_handler(event, context): | ||
| fullReportEmail = ['[email protected]', '[email protected]'] | ||
| fullReportEmail = ['[email protected]', '[email protected]', '[email protected]'] |
There was a problem hiding this comment.
Suggested change
| fullReportEmail = ['alexander.tymchuk@percona.com', '[email protected]', '[email protected]'] | |
| fullReportEmail = ['alexander.demidoff@percona.com', '[email protected]', '[email protected]'] |
There was a problem hiding this comment.
btw, I don't remember when I got an email )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cost Calculation Fix for EC2 Instance Reporting
Purpose
Lambda function that runs nightly to email instance owners about their running staging EC2 instances, including uptime and estimated costs, to remind them to shut down unused resources.
Before
After
Additional fixes: Spot/on-demand detection, Linux-only pricing, Python 3 compatibility, enhanced email formatting.