testing with earlier go version #2681
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaushikpuneet07
force-pushed
the
check-go
branch
2 times, most recently
from
54f60f8
to
1d6644d
Compare
kaushikpuneet07
force-pushed
the
check-go
branch
from
a4ff9fa
to
bfefa5d
Compare
kaushikpuneet07
force-pushed
the
check-go
branch
3 times, most recently
from
09212a6
to
a38ee4a
Compare
kaushikpuneet07
force-pushed
the
check-go
branch
from
a38ee4a
to
4667000
Compare
kaushikpuneet07
force-pushed
the
check-go
branch
from
443ccc7
to
87bfb8c
Compare
Comment on lines
+17
to
+19
| sudo yum -y install wget | ||
| wget https://mirror.stream.centos.org/9-stream/AppStream/x86_64/os/Packages/gcc-c++-11.4.1-2.3.el9.x86_64.rpm | ||
| wget https://mirror.stream.centos.org/9-stream/AppStream/x86_64/os/Packages/gcc-11.4.1-2.3.el9.x86_64.rpm |
There was a problem hiding this comment.
why we cannot install these packages from the repo
| @@ -55,7 +65,7 @@ elif [ -f /usr/bin/apt ]; then | |||
| fi | |||
|
|
|||
| # We need to use golang version >= 1.21. Downloading golang from tarball to ensure each platform uses the same version. | |||
| sudo wget https://go.dev/dl/go1.21.9.linux-amd64.tar.gz | |||
| sudo wget https://go.dev/dl/go1.17.7.linux-amd64.tar.gz | |||
There was a problem hiding this comment.
why such old golang version? there are a lot of cves in it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Job was failing because of go version , reverting to old one . Tested and verified , job looks good with earlier go version