Fix for not propagating the original exception #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks Marc, I'll merge it and make a minor change before putting that to CPAN |
vanHoesel
approved these changes
May 10, 2024
Contributor
vanHoesel
left a comment
vanHoesel
left a comment
There was a problem hiding this comment.
I would prefer to name the variable something like $error_message
Author
|
Yes that’s better. More human readable. And fitting better in the code style of the project. Snake instead of camel case. Verstuurd vanaf mijn iPhoneOp 10 mei 2024 om 16:28 heeft Theo van Hoesel ***@***.***> het volgende geschreven:
@vanHoesel approved this pull request.
I would prefer to name the variable something like $error_message
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Contributor
|
This PR has been included in #4. That one has been published on CPAN already |
Contributor
|
This PR can be closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue: https://issues/2
The value of $@ was replaced before it's 'rethrown'.