Transforms SelectPauliRot (phase gradient)#8738
Conversation
|
Hello. You may have forgotten to update the changelog!
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8738 +/- ##
=======================================
Coverage 99.37% 99.37%
=======================================
Files 589 589
Lines 63179 63181 +2
=======================================
+ Hits 62784 62786 +2
Misses 395 395 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Qottmann
left a comment
There was a problem hiding this comment.
On a first pass it looks very nice and clean! Great job @KetpuntoG !
Missing some things in the doc string though
Co-authored-by: Utkarsh <utkarshazad98@gmail.com>
dwierichs
left a comment
There was a problem hiding this comment.
Nice work @KetpuntoG, this is so cool to have implemented essentially in a couple of lines 😍
Co-authored-by: David Wierichs <david.wierichs@xanadu.ai>
…aneAI/pennylane into multiplexer_decomposition
dwierichs
left a comment
There was a problem hiding this comment.
Looks good to me, nice work @KetpuntoG 🎉
Can I ask you to add some explanation for the updated ceiling+flooring logic for the rounding? I'm not sure what exactly is going on :D
Approving conditional on that small request :)
Qottmann
left a comment
There was a problem hiding this comment.
looks good, thanks @KetpuntoG !
just a small suggestion to update the image
Co-authored-by: Korbinian Kottmann <43949391+Qottmann@users.noreply.github.com>
…aneAI/pennylane into multiplexer_decomposition
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
test directory!
All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
doc/releases/changelog-dev.mdfile, summarizing thechange, and including a link back to the PR.
The PennyLane source code conforms to
PEP8 standards.
We check all of our code against Pylint.
To lint modified files, simply
pip install pylint, and thenrun
pylint pennylane/path/to/file.py.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
A new state of the art decomposition has been added to SelectPauliRot (as a transform) in qml.labs
Possible Drawbacks:
This is a transform so it will not be part of the decomposition graph