-
Notifications
You must be signed in to change notification settings - Fork 49
Upgrade isort/pylint #1288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade isort/pylint #1288
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1288 +/- ##
==========================================
- Coverage 93.70% 89.88% -3.82%
==========================================
Files 241 185 -56
Lines 39768 28690 -11078
==========================================
- Hits 37263 25788 -11475
- Misses 2505 2902 +397
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jzaia18
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Is this part of the effort to standardize these versions between the repos?
indeed - Pennylane and Catalyst have already pinned to these versions too. There will be a broader discussion about how to centralize these requirements. |
LuisAlfredoNu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐂
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
testsdirectory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
.github/CHANGELOG.mdfile, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
Bump pylint/isort/black to match PennyLane.
PennyLaneAI/pennylane#8506
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-103752]