Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrated the automated version bump code to the cirq plugin #82

Merged
merged 8 commits into from
Nov 2, 2021
Merged

Integrated the automated version bump code to the cirq plugin #82

merged 8 commits into from
Nov 2, 2021

Conversation

Jaybsoni
Copy link
Contributor

@Jaybsoni Jaybsoni commented Nov 1, 2021

No description provided.

@Jaybsoni Jaybsoni requested a review from antalszava November 1, 2021 20:56
@codecov
Copy link

codecov bot commented Nov 1, 2021 •
edited
Loading

Codecov Report

Merging #82 (695f682) into master (49f81b9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #82   +/-   ##
=======================================
  Coverage   99.23%   99.23%           
=======================================
  Files           8        8           
  Lines         391      391           
=======================================
  Hits          388      388           
  Misses          3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49f81b9...695f682. Read the comment docs.

@rmoyard rmoyard self-requested a review November 2, 2021 08:13
@Jaybsoni
Copy link
Contributor Author

Jaybsoni commented Nov 2, 2021

Can I disable the Codefactor issue? Or should I include a module level doctoring?

@josh146
Copy link
Member

josh146 commented Nov 2, 2021

@Jaybsoni best to add a docstring in this case, describing the file. Can be brief/1-2 lines, e.g.,

"""This module contains functions for ..."""

rmoyard
rmoyard reviewed Nov 2, 2021
View reviewed changes
.github/workflows/pre_release_version_bump.yml
@@ -0,0 +1,38 @@
name: Manually Triggered Version Bumps
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jaybsoni Just out of curiosity, how do you trigger it manually? Does it create a button on github?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, yes you go under the actions tab and it should be titled 'Manually Triggered Version Bumps'. Upon selecting it, it will run

@Jaybsoni Jaybsoni requested a review from rmoyard November 2, 2021 18:23
antalszava
antalszava approved these changes Nov 2, 2021
View reviewed changes
Copy link
Contributor

@antalszava antalszava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👌

@Jaybsoni Jaybsoni merged commit cba380e into master Nov 2, 2021
@Jaybsoni Jaybsoni deleted the auto_vb branch November 2, 2021 19:26
@antalszava
Copy link
Contributor

[sc-10712]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antalszava antalszava antalszava approved these changes

@rmoyard rmoyard Awaiting requested review from rmoyard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jaybsoni @josh146 @antalszava @rmoyard