Clip negative values in extrapolation interfaces #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #213 +/- ##
==========================================
- Coverage 48.75% 48.74% -0.02%
==========================================
Files 56 56
Lines 7423 7425 +2
Branches 1015 1015
==========================================
Hits 3619 3619
- Misses 3586 3588 +2
Partials 218 218 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mattcieslak
approved these changes
Mar 11, 2025
| @@ -385,6 +387,8 @@ def _extrapolate_scheme(self, scheme_name, runtime, fit_obj, mask_array, mask_im | |||
| shore_array = fit_obj._shore_coef[mask_array] | |||
| output_data = np.zeros(mask_array.shape + (len(prediction_gtab.bvals),)) | |||
| output_data[mask_array] = np.dot(shore_array, prediction_shore.T) | |||
| # Clip negative values | |||
There was a problem hiding this comment.
No need for s0=1000 here because it was fit with the original s0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #212.
Changes proposed in this pull request