Use DIPY version of patch2self #902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #902 +/- ##
==========================================
+ Coverage 44.22% 45.80% +1.57%
==========================================
Files 66 65 -1
Lines 9835 9718 -117
Branches 1096 1062 -34
==========================================
+ Hits 4350 4451 +101
+ Misses 5262 5040 -222
- Partials 223 227 +4 ☔ View full report in Codecov by Sentry. |
mattcieslak
approved these changes
Dec 11, 2024
| @@ -62,6 +67,7 @@ def _calculate_nmse(self, original_nii, corrected_nii): | |||
| pd.DataFrame( | |||
| {title + '_pre': pres, title + '_post': posts, title + '_change': differences} | |||
| ).to_csv(output_file, index=False) | |||
| self._nmse_text = output_file | |||
There was a problem hiding this comment.
This is really clever!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #893.
Changes proposed in this pull request
patch2selfand use version imported from dipy.