-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue #283: Rename Key Group to Entity Set #329
Conversation
Hi @tsalo and @mattcieslak - circleci failed because it used ubuntu-2004:202201-02, which is now deprecated and not available . I want to change the config.yml file so that it uses one of the current images, but I'm not sure if it will break anything else. Do you have any preference on which image to use? |
Any of those should be ok |
a294c61
to
68b4962
Compare
For [email protected], data_path argument is before all other arguments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one requested change. Also, this is a breaking change, so I'd add a breaking-change
label to the PR and we need to make sure the next release is a major one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent!! I like the new name much better
Co-authored-by: Matt Cieslak <[email protected]>
Closes #283. <-- Taylor: put the issue you're addressing here so merging the PR will close the issue
Changes proposed in this pull request