Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize packaging and hopefully fix tests #267

Merged
merged 55 commits into from
Jan 12, 2024
Merged

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Sep 7, 2023

Closes #269.

Changes proposed:

  • Remove the Docker and Singularity build/test steps from the CircleCI config.
  • Replace setuptools-based packaging with hatch. This means dropping setup.py, setup.cfg, tox.ini, and requirements.txt in favor of pyproject.toml. It should also infer the correct version string, rather than relying on a hardcoded version in the code.
  • Move the test files into cubids/tests.
  • Add a CITATION.cff file with the Zenodo authors and the CuBIDS paper.
  • Remove unused package*.json files.

@tsalo
Copy link
Member Author

tsalo commented Sep 7, 2023

I'm stumped. I need to install CuBIDS in the CircleCI Docker image in order to access the package's version, because the version is then fed into the built CuBIDS Docker image, but I can't seem to get a base image with Docker installed within it and Python 3.8+ (which is necessary to install a Python library using pyproject.toml).

@tsalo
Copy link
Member Author

tsalo commented Sep 8, 2023

CircleCI has both Docker executors and machine executors. The machine executor can run Docker without having to set up a remote docker.

@tsalo tsalo requested a review from mattcieslak September 8, 2023 18:08
@tsalo
Copy link
Member Author

tsalo commented Sep 8, 2023

It's working!

@tsalo
Copy link
Member Author

tsalo commented Sep 13, 2023

@mattcieslak if we can tackle this PR next, it should lead into #268 pretty cleanly.

@mattcieslak mattcieslak self-assigned this Oct 30, 2023
pyproject.toml Show resolved Hide resolved
@tsalo tsalo merged commit 068e319 into PennLINC:main Jan 12, 2024
@tsalo tsalo deleted the packaging branch January 12, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop building Docker image
2 participants