cdc flow: continue as new after state updates #2420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ideally we'd move to fully immutable state, but that just isn't the golang way |
|
is there a way to write a test for this? |
Maybe by checking that RunID changes. Will look into |
serprex
force-pushed
the
more-continue-as-new
branch
from
640370f to
068c67b
Compare
iskakaushik
approved these changes
Jan 9, 2025
serprex
force-pushed
the
more-continue-as-new
branch
2 times, most recently
from
10b0142 to
7caf976
Compare
this prevents rewinding state to start of workflow from undoing changes to settings (such as table additions/removals)
serprex
force-pushed
the
more-continue-as-new
branch
from
7caf976 to
530d07f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this prevents rewinding state to start of workflow from undoing changes to settings (such as table additions/removals)