Increase retry initial backoff to 1 minute #2418
Merged
+47
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Retrying in 1 sec very rarely changes things as we typically tend to wait for database auto-scaling, network issue resolution or other error types wherre we would anyways need to wait in the order of minuted. It was also causing alert spamming in the systems basically making them not usable for a certain kind of errors.
iskakaushik
requested review from
serprex,
heavycrystal,
Amogh-Bharadwaj and
iamKunalGupta
serprex
approved these changes
Jan 8, 2025
flow/workflows/drop_flow.go
Outdated
| @@ -82,6 +86,9 @@ func DropFlowWorkflow(ctx workflow.Context, input *protos.DropFlowInput) error { | |||
| dropStatsCtx := workflow.WithActivityOptions(ctx, workflow.ActivityOptions{ | |||
| StartToCloseTimeout: 1 * time.Minute, | |||
There was a problem hiding this comment.
Maybe we should increase this and other places where StartToCloseTimeout is 1 minute and initial interval is also 1 minute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retrying in 1 sec very rarely changes things as we typically tend to wait for database auto-scaling, network issue resolution or other error types wherre we would anyways need to wait in the order of minuted.
It was also causing alert spamming in the systems basically making them not usable for a certain kind of errors.