Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClickHouse resync: remove soft-delete transfer #2411

Merged
merged 2 commits into from
Jan 6, 2025
+0 −16
Merged

ClickHouse resync: remove soft-delete transfer #2411

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77ff40d
add final to soft-delete transfer
Amogh-Bharadwaj Jan 6, 2025
e894ac8
remove soft-deletes transfer altogether
Amogh-Bharadwaj Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions flow/connectors/clickhouse/cdc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import (
"errors"
"fmt"
"log/slog"
"strings"

"github.com/ClickHouse/clickhouse-go/v2"
_ "github.com/ClickHouse/clickhouse-go/v2/lib/driver"
Expand Down Expand Up @@ -178,21 +177,6 @@ func (c *ClickHouseConnector) RenameTables(
}

if originalTableExists {
tableSchema := tableNameSchemaMapping[renameRequest.CurrentName]
columnNames := make([]string, 0, len(tableSchema.Columns))
for _, col := range tableSchema.Columns {
columnNames = append(columnNames, col.Name)
}

allCols := strings.Join(columnNames, ",")
c.logger.Info("handling soft-deletes for table before rename", slog.String("NewName", renameRequest.NewName))
if err := c.execWithLogging(ctx,
fmt.Sprintf("INSERT INTO `%s`(%s,%s) SELECT %s,true FROM `%s` WHERE %s = 1",
renameRequest.CurrentName, allCols, signColName, allCols, renameRequest.NewName, signColName),
); err != nil {
return nil, fmt.Errorf("unable to handle soft-deletes for table %s: %w", renameRequest.NewName, err)
}

// target table exists, so we can attempt to swap. In most cases, we will have Atomic engine,
// which supports a special query to exchange two tables, allowing dependent (materialized) views and dictionaries on these tables
c.logger.Info("attempting atomic exchange",
Expand Down
Loading