-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SyncFlow: top level heartbeat #2401
Conversation
we lose more visibility into which phase of a batch we are in |
yes, tho with parallelism heartbeats were already stepping over each other. With changes to parallelism in last normalize change I'm wanting to move towards parallelism being on by default |
@serprex - can we have this heartbeat contain a message that shows the consolidated status of syncs and normalizes, something like:
|
5970177
to
ac39606
Compare
updated with heartbeat state I think will be useful. Temporal already has timestamps on heartbeat, no need to put timestamps in message |
was seeing heartbeat timeouts
ac39606
to
6d65399
Compare
|
||
var currentSyncFlowNum atomic.Int32 | ||
var totalRecordsSynced atomic.Int64 | ||
var normalizingBatchID atomic.Int64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: could probably store some of these in substruct of FlowableActivity
and keep calls clean
was seeing heartbeat timeouts