Skip to content

Commit

Permalink
does this actually cause fail
Browse files Browse the repository at this point in the history
  • Loading branch information
serprex committed Dec 24, 2024
1 parent 65d3f56 commit 6dc1df2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion flow/e2e/clickhouse/peer_flow_ch_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -804,7 +804,7 @@ func (s ClickHouseSuite) Test_IgnoreViewWithMissingTable() {
require.NoError(s.t, ch.Exec(context.Background(), fmt.Sprintf(
"create view v as select id from %s union all select id from test_ignore_view_drop", dstTableName,
)))
require.NoError(s.t, ch.Exec(context.Background(), "drop table test_ignore_view_drop"))
// require.NoError(s.t, ch.Exec(context.Background(), "drop table test_ignore_view_drop"))

Check failure on line 807 in flow/e2e/clickhouse/peer_flow_ch_test.go

View workflow job for this annotation

GitHub Actions / lint

commentedOutCode: may want to remove commented-out code (gocritic)

_, err = s.Conn().Exec(context.Background(), fmt.Sprintf("INSERT INTO %s (id) VALUES (1)", srcTableName))
require.NoError(s.t, err)
Expand Down

0 comments on commit 6dc1df2

Please sign in to comment.