-
Notifications
You must be signed in to change notification settings - Fork 20
context metadata cleanup #225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
dlebauer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ayushman1210 thank you for reporting this bug and submitting these changes.
Unfortunately, it looks like these changes. Include your updates to documentation, maybe the same as are in #203.
Could you please either take those files out of this PR or submit a new one so that the PR is focused on the related issue? Either approach would be fine.
And as a minor request, for future reference - it is helpful if you can prepend the branch name and pr title with the feature number.
|
Thanks @ayushman1210 - I'll defer to @Alomir for approval. |
Alomir
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work! One name change suggestion, but more importantly a possible way to work around the false clang error.
Co-authored-by: Mike Longfritz <[email protected]>
… one at a time until the hash is empty
|
hey @Alomir please review this PR when you have some free time I have made changes as you suggested |
Created destroyContextMetadata() that
Added call to destroyContextMetadata() at the end of cleanupModel() function
Implementation Details
The implementation uses the uthash library's HASH_ITER and HASH_DEL macros for safe iteration and deletion:
Fixes
#211