Skip to content

Added an Animation to the footer to enhance UI. #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

divine7022
Copy link
Contributor

  • Added an animation in the footer to enhance the footer.
  • Made the Animation to appear only in the Home page.
Untitled.video.-.Made.with.Clipchamp.mp4

image

@dlebauer please let me know whether you this feature ?.

@divine7022
Copy link
Contributor Author

@dlebauer let me know if there are any modification need to be done.
Thank you

@dlebauer
Copy link
Member

@divine7022 thanks - this is a neat idea - where did you get this animation? Is it possible to generate an animation that is more closely connected to PEcAn - e.g. grasslands, forests, crops, earth system?

@divine7022
Copy link
Contributor Author

@divine7022 thanks - this is a neat idea - where did you get this animation? Is it possible to generate an animation that is more closely connected to PEcAn - e.g. grasslands, forests, crops, earth system?

@dlebauer okey, definitely i will try to generate an animation that aligns more with PEcAn’s themes.

@divine7022
Copy link
Contributor Author

@divine7022 thanks - this is a neat idea - where did you get this animation? Is it possible to generate an animation that is more closely connected to PEcAn - e.g. grasslands, forests, crops, earth system?

@dlebauer created this animation using css

@allgandalf
Copy link
Collaborator

Wow this is fancy 😆 , not sure if we want this though, animations often slow site loading, on top of it, we deploy our site to github pages (a free runner) so not sure how this affects on performance.

With that said, I have no problem merging this if @dlebauer feels this is fine, passing over it to you @dlebauer 😄

@allgandalf
Copy link
Collaborator

@divine7022 thanks - this is a neat idea - where did you get this animation? Is it possible to generate an animation that is more closely connected to PEcAn - e.g. grasslands, forests, crops, earth system?

Oops this is already reviewed by you, completely missed it sorry!

@divine7022
Copy link
Contributor Author

divine7022 commented Feb 20, 2025

Wow this is fancy 😆 , not sure if we want this though, animations often slow site loading, on top of it, we deploy our site to github pages (a free runner) so not sure how this affects on performance.

With that said, I have no problem merging this if @dlebauer feels this is fine, passing over it to you @dlebauer 😄

@allgandalf Thank for your review
since this is created only using "CSS" it dosen't slow's the site loading , it is completely working normal. On top of it the animation is made to visible only in the Home page not in all the pages.

see the video:

Untitled.video.-.Made.with.Clipchamp.1.mp4

@dlebauer
Copy link
Member

@divine7022

Re: #88 (comment)

@dlebauer okey, definitely i will try to generate an animation that aligns more with PEcAn’s themes.

I don't see any changes to the animation. Is it difficult to create?

@divine7022
Copy link
Contributor Author

divine7022 commented Feb 26, 2025

@divine7022

Re: #88 (comment)

@dlebauer okey, definitely i will try to generate an animation that aligns more with PEcAn’s themes.

I don't see any changes to the animation. Is it difficult to create?

@dlebauer Hello sir!

  • I am currently exploring the best animation that aligns with the PEcAn theme. It’s a bit complex, but I am actively working on it and will bring the changes soon!

  • In addition, I am working on enhancing the search bar functionality—not just to retrieve static content results but also to index and search the content of the develop branch from the documentation using Algolia’s crawler. This process is more challenging than it seems, with several hurdles to overcome, but I am making steady progress.

  • I also have several enhancements and new features in mind, which I plan to implement soon.

  • Additionally, I am brainstorming project ideas.

Let me know if you have any feedback or suggestions!
Thank you!

@allgandalf
Copy link
Collaborator

hey @divine7022 , can you please create individual issues for your ideas and focus on adding the requested animation in this PR?

@divine7022
Copy link
Contributor Author

hey @divine7022 , can you please create individual issues for your ideas and focus on adding the requested animation in this PR?

@allgandalf Sure sir,
sir i have already created the UI of first section of the website and working on other section of the website.

@allgandalf
Copy link
Collaborator

hi @divine7022 any update on the requested changes?

@divine7022
Copy link
Contributor Author

@allgandalf Hello sir,
I apologize for the inconvenience. Since i was occupied with other tasks that had higher priority, so I couldn't focus on this earlier. However, I will get to it soon. Thanks for your patience!

@allgandalf
Copy link
Collaborator

hey @divine7022 , can you get this one done this week? thanks! 😄

@divine7022
Copy link
Contributor Author

hey @divine7022 , can you get this one done this week? thanks! 😄

@allgandalf hello sir,
Apologies for the delay, and i appreciate your patience. I will consider doing this ASAP.

Thank you!

@divine7022
Copy link
Contributor Author

Untitled.video.-.Made.with.Clipchamp.1.1.mp4

@allgandalf @dlebauer
First, I’d like to apologize for the poor video quality, but in reality, the quality is high. Please feel free to share your feedback, I’m open to iterate it based on your suggestions.

Thank you!

@allgandalf
Copy link
Collaborator

@divine7022 can you also push this code to this branch, worst case we revert the commit but i want to test this locally

@divine7022
Copy link
Contributor Author

@divine7022 can you also push this code to this branch, worst case we revert the commit but i want to test this locally

Sure, there are a few modifications I need to make. I’ll push the code once they’re done.
Thanks for your feedback.

@divine7022
Copy link
Contributor Author

divine7022 commented Mar 20, 2025

@allgandalf @dlebauer

Hello sir,
I have added a footer animation that appears only on the homepage. Additionally, when the user scrolls down to the footer, the navbar color smoothly changes to match it, creating a better visual experience. These changes are designed only for the homepage and won't interfere with other pages(eg: Documentation, About etc.. )
Thank you!

Recording.2025-03-20.110607.1.mp4

@allgandalf
Copy link
Collaborator

On my To-do list for this week...

Copy link
Member

@dlebauer dlebauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, looks good to me!

@allgandalf
Copy link
Collaborator

@divine7022 CI build is failing, please have a look

@divine7022
Copy link
Contributor Author

Cool, looks good to me!

I'm glad you liked it. Thanks for your feedback.

@divine7022
Copy link
Contributor Author

@divine7022 CI build is failing, please have a look

Thanks for the update! issue fixed

@dlebauer
Copy link
Member

@allgandalf is this ready to merge?

@allgandalf
Copy link
Collaborator

allgandalf commented Mar 27, 2025

haven't found time to test it yet, lets wait till weekend, I want to review this one on small screens (mobile) so lets hold the merge

@divine7022
Copy link
Contributor Author

divine7022 commented Mar 27, 2025

The animation has no responsiveness issues and is ready to merge as is. However, I noticed a responsiveness issue in the Acknowledgements section, specifically, the Navicat and AWS logos should shift down at smaller breakpoints. I'll fix this soon.

image

Issue:
image

Thank you!

@divine7022
Copy link
Contributor Author

@dlebauer and @allgandalf
Hello sir, I've opened a PR(#105) to address the issue commented above. Whenever you have a moment, please take a look and review it. Let me know if any further changes are needed.

@dlebauer
Copy link
Member

Thanks @divine7022. I've merged #105.

@dlebauer
Copy link
Member

@allgandalf okay to merge this one?

Copy link
Collaborator

@allgandalf allgandalf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks amazing, thanks for all the hard work in this @divine7022 I really appreciate your efforts.

It works fine on small screens too:

ScreenRecording_04-26-2025.17-38-55_1.MP4

Let's merge this PR 💪 , @dlebauer I would have merged it but i don't see your approval on the new code changes yet, feel free to merge this one after you approve, LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants