-
Notifications
You must be signed in to change notification settings - Fork 16
Added an Animation to the footer to enhance UI. #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@dlebauer let me know if there are any modification need to be done. |
@divine7022 thanks - this is a neat idea - where did you get this animation? Is it possible to generate an animation that is more closely connected to PEcAn - e.g. grasslands, forests, crops, earth system? |
@dlebauer okey, definitely i will try to generate an animation that aligns more with PEcAn’s themes. |
@dlebauer created this animation using css |
Wow this is fancy 😆 , not sure if we want this though, animations often slow site loading, on top of it, we deploy our site to github pages (a free runner) so not sure how this affects on performance. With that said, I have no problem merging this if @dlebauer feels this is fine, passing over it to you @dlebauer 😄 |
Oops this is already reviewed by you, completely missed it sorry! |
@allgandalf Thank for your review see the video: Untitled.video.-.Made.with.Clipchamp.1.mp4 |
Re: #88 (comment)
I don't see any changes to the animation. Is it difficult to create? |
@dlebauer Hello sir!
Let me know if you have any feedback or suggestions! |
hey @divine7022 , can you please create individual issues for your ideas and focus on adding the requested animation in this PR? |
@allgandalf Sure sir, |
hi @divine7022 any update on the requested changes? |
@allgandalf Hello sir, |
hey @divine7022 , can you get this one done this week? thanks! 😄 |
@allgandalf hello sir, Thank you! |
Untitled.video.-.Made.with.Clipchamp.1.1.mp4@allgandalf @dlebauer Thank you! |
@divine7022 can you also push this code to this branch, worst case we revert the commit but i want to test this locally |
Sure, there are a few modifications I need to make. I’ll push the code once they’re done. |
Hello sir, Recording.2025-03-20.110607.1.mp4 |
On my To-do list for this week... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, looks good to me!
@divine7022 CI build is failing, please have a look |
I'm glad you liked it. Thanks for your feedback. |
Thanks for the update! issue fixed |
@allgandalf is this ready to merge? |
haven't found time to test it yet, lets wait till weekend, I want to review this one on small screens (mobile) so lets hold the merge |
@dlebauer and @allgandalf |
Thanks @divine7022. I've merged #105. |
@allgandalf okay to merge this one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks amazing, thanks for all the hard work in this @divine7022 I really appreciate your efforts.
It works fine on small screens too:
ScreenRecording_04-26-2025.17-38-55_1.MP4
Let's merge this PR 💪 , @dlebauer I would have merged it but i don't see your approval on the new code changes yet, feel free to merge this one after you approve, LGTM!
Untitled.video.-.Made.with.Clipchamp.mp4
@dlebauer please let me know whether you this feature ?.