Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #118
Hey @Paxa
it seems that this line from app.js is not working on Windows:
root: remote.app.MainFilename.replace(/\/(index\.html|main\.js)/, ''),
here's the error from console when I try to open "See History", you can see that
/index.html
is not removed :Same when I open snippets.
So I changed the way we get the root of the app, and now it works on my Windows machine
root: remote.app.getAppPath()
you can see getAppPath() documentation here:
https://github.com/electron/electron/blob/master/docs/api/app.md#appgetapppath