Add tests for Strava #200
Add tests for Strava #200
Conversation
Codecov Report
@@ Coverage Diff @@
## main #200 +/- ##
==========================================
+ Coverage 87.12% 87.42% +0.29%
==========================================
Files 82 82
Lines 668 668
Branches 128 123 -5
==========================================
+ Hits 582 584 +2
+ Misses 54 53 -1
+ Partials 32 31 -1
Continue to review full report at Codecov.
|
| Some activities have maps and some have photos, so it's not reliable to check for either | ||
| using this setup with storybook running. | ||
| */ | ||
| cy.getIframeBody().find('.content').should('exist'); |
There was a problem hiding this comment.
This is a fair point. I think for now this is totally fine. our "sprint goal" if you like was just to have integration tests in place to ensure the provider scripts actually loads. What it loads based on props that configure it will likely come later. On pretty much all components we need to come up with a url constructor method unique to each component which can then be tested. Once that's done we can probably look to dig in a little more with E2E tests. Great job on this though... Thanks
There was a problem hiding this comment.
Yep, that's great! I thought we'd benefit from having this in there at some point - I thought a comment makes sense for the next person who might work on it. 👍
Thanks for taking a look so quickly!
PaulieScanlon
added
hacktoberfest
* Add Strava unit tests; fixes PaulieScanlon#117 * Add Strava integration tests; fixes PaulieScanlon#118
Adding the missing unit and integration tests for Strava, related to #71