removed hardhat-deploy due to compilation issue #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR. Let's wait for that PR upstream to be resolved. |
|
I'd recommend against that, its not moving particularly fast and main branch is currently broken. |
|
Got it, in this case, I'll review later. Quick question - how difficult would it be to refactor the deployment script to make it work without hardhat-deploy? |
|
I have merged this to unblock the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #186
But removes hardhat-deploy plugin, and thus breaks deployment scripts. Feel free to repurpose.
Might be resolved anyway by upstream PR on hardhat-deploy wighawag/hardhat-deploy#511
@PaulRBerg it's up to you what you want to do, but I suggest removing hardhat-deploy support for now