Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace greeter with lock contract #182

Merged
merged 3 commits into from
Dec 31, 2023
Merged

refactor: replace greeter with lock contract #182

merged 3 commits into from
Dec 31, 2023

Conversation

zikyfranky
Copy link
Contributor

This is a PR for the #141 issue

@zikyfranky
Copy link
Contributor Author

Let me know if there's any refactoring needed @PaulRBerg

Compliments of the season.

@PaulRBerg
Copy link
Owner

Thanks for the PR, @zikyfranky. I wanted to push some changes to your fork but it looks like you didn't give me permission to do that?

https://app.warp.dev/block/TcqJ9dWwVISwoSJAjK57ot

@zikyfranky
Copy link
Contributor Author

I have "Allow edits by maintainers" enabled, isn't that supposed to give you write access?

Screenshot 2023-12-25 at 7 09 39 PM

Anyways, if that's not the case, how do I grant you access without explicitly adding you as a collaborator?

I did send you an invite should that be the only route possible

@PaulRBerg
Copy link
Owner

"Allow edits by maintainers" works only for non-main branches. You made your changes directly on main.

Thanks for giving me access.

@PaulRBerg
Copy link
Owner

I'm still not able to push it to your fork, and I don't know why. Can you cherry-pick the changes from this branch, please?

https://github.com/PaulRBerg/hardhat-template/tree/zikyfranky-main

@zikyfranky
Copy link
Contributor Author

@PaulRBerg Should be good now.

@PaulRBerg PaulRBerg merged commit f43ec3c into PaulRBerg:main Dec 31, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants