Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated App Structure and Build for Easier Development Workflow #116

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

DeanPoulin
Copy link

I've been doing a lot of front end JS development lately using the gulp build process and I've found it to be really awesome. I noticed you've got some things in here that can be easier accomplished leveraging a gulp type build. You might want to rev this change to be 0.4.0 since the main artifact is located in a different place and I'm sure a lot of developers have the bower dependency specified as 0.3.x.

So here it is:

Some key differences, there's now a dist directory where the deployable artifacts are created via gulp. With the addition of jsHint, it complained about a few things, so I resolved those issues.

Here's what was done:

  • Added gulp build with uglify, ngAnnotate, etc...
  • Added bower dependency on Angular (Should this be 1.x vs 1.2.x?)
  • Added jshint
  • Fixed jshint errors in code
    • line 1 col 13 Strings must use singlequote.
    • line 18 col 35 Strings must use singlequote.
    • line 36 col 19 Strings must use singlequote.
    • line 140 col 44 Expected '!==' and instead saw '!='.
    • line 158 col 20 Don't make functions within a loop.
    • line 167 col 26 'ctrl' is already defined.
    • line 204 col 18 Don't make functions within a loop.
    • line 232 col 28 Strings must use singlequote.
    • line 292 col 19 Bad line breaking before '&&'.
    • line 301 col 59 Strings must use singlequote.
  • Added .gitignore
  • New development workflow:
    1. npm install
    2. make development changes
    3. gulp build
    4. tag repository

Dean Poulin added 2 commits January 30, 2015 14:50
- Added bower dependency on Angular (Should this be 1.x vs 1.2.x?)
- Added jshint
- Fixed jshint errors in code
  line 1    col 13  Strings must use singlequote.
  line 18   col 35  Strings must use singlequote.
  line 36   col 19  Strings must use singlequote.
  line 140  col 44  Expected '!==' and instead saw '!='.
  line 158  col 20  Don't make functions within a loop.
  line 167  col 26  'ctrl' is already defined.
  line 204  col 18  Don't make functions within a loop.
  line 232  col 28  Strings must use singlequote.
  line 292  col 19  Bad line breaking before '&&'.
  line 301  col 59  Strings must use singlequote.
- Added gulp build with uglify, ngAnnotate, etc...
- Added .gitignore
- New development workflow: 1) npm install 2) make development changes 3) gulp build 4) tag repository
@Pasvaz
Copy link
Owner

Pasvaz commented Jan 30, 2015

Nice job, thank you. I'll test and commit it asap

@DeanPoulin
Copy link
Author

Awesome. This helped us to solve some major performance issues, thanks a million! With this type of build we can break the source into multiple files as well to help with separation of concerns and eventually add some simple tests to validate how the component should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants