Skip to content

Fix PalettedContainer$Data#createOrReuseData param #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix PalettedContainer$Data#createOrReuseData param #341

wants to merge 1 commit into from

Conversation

@jpenilla
Copy link

@jpenilla jpenilla commented Sep 23, 2025 •
edited
Loading 

    private PalettedContainer.Data<T> createOrReuseData(@Nullable PalettedContainer.Data<T> data, int bits) {
        Configuration configurationForBitCount = this.strategy.getConfigurationForBitCount(bits);

@jpenilla jpenilla requested a review from a team as a code owner September 23, 2025 05:26
@CLAassistant
Copy link

CLAassistant commented Sep 23, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

marchermans
marchermans requested changes Sep 25, 2025
View reviewed changes
data/net/minecraft/world/level/chunk/PalettedContainer.mapping
METHOD createOrReuseData (Lnet/minecraft/world/level/chunk/PalettedContainer$Data;I)Lnet/minecraft/world/level/chunk/PalettedContainer$Data;
ARG 1 data
ARG 2 id
ARG 2 bits
Copy link
Member

@marchermans marchermans Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would bitCount not be a better option?

@jpenilla jpenilla closed this Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marchermans marchermans marchermans requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jpenilla @CLAassistant @marchermans